Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to build on Ubuntu 20.04 ROS Noetic #6

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

fratopa
Copy link
Contributor

@fratopa fratopa commented Feb 19, 2023

Hi! I and at least another user had a few problems compiling your repo.
I changed every instance of #include <Eigen/ to #include <eigen3/Eigen/ and every instance of default(none) to /*default(none)*/ in order to compile correctly.

Furthermore, having compiled and run a few of the examples I noticed that i couldn't visualize the point-cloud coming from the sensor on Rviz. To solve the problem I changed every instance of /world into world.

Now everything works correctly, thanks again for having shared your code!

@fratopa fratopa mentioned this pull request Feb 19, 2023
@jackykongfz jackykongfz changed the base branch from main to ubuntu20 February 20, 2023 09:48
@jackykongfz jackykongfz merged commit 506a2aa into hku-mars:ubuntu20 Feb 20, 2023
@jackykongfz
Copy link
Collaborator

Really thanks for your contribution! I have merged your code into a new branch call ubuntu20, sorry for my late reply. In fact I already solved the problem before by adding the variables into the "shared{}", but you solution also worked! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants