Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(29159): Improve the integration of the adapter page with the workspace #731

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Jan 6, 2025

See https://hivemq.kanbanize.com/ctrl_board/57/cards/29159/details/

The PR is the first step in resolving the lack of context for managing tsgs, topic filters and mappings in the workspace after creating a new adapter in a different context of the application

In the adapter list, the PR adds several items in the contextual menu ("actions£) of an adapter, under the common group "Manage from Workspace":

  • Device Tags
  • Topic Filters
  • Northbound mappings
  • Southbound mapping (if enabled for the adapter)
  • Adapter and Device

Each of the commands links to the relevant node on the workspace. The transition is animated, with a managed zoom ("fit view") on the relevant node(s).

The animation and zoom should help to contextualise the different elements of an adapter that requires further management from the workspace

Out-of-scope

  • Allowing the creation of an adapter directly from the workspace, which will also improve the intergration will be implemented in subsequent tickets

Before

screenshot-localhost_3000-2025_01_06-19_47_28

screenshot-localhost_3000-2025_01_06-19_47_53

After

screenshot-localhost_3000-2025_01_06-19_50_58

screenshot-localhost_3000-2025_01_06-19_51_09

screenshot-localhost_3000-2025_01_06-19_51_26

@vanch3d vanch3d self-assigned this Jan 6, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 6, 2025
@vanch3d vanch3d requested a review from sfrehse January 8, 2025 16:44
@sfrehse
Copy link
Contributor

sfrehse commented Jan 8, 2025

Why the link to the topic filters?

@vanch3d
Copy link
Contributor Author

vanch3d commented Jan 10, 2025

Why the link to the topic filters?

To be consistent with the process. Topic filters are required for the mappings

Copy link
Contributor

@oli-hivemq oli-hivemq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice style too 🦣
Not super important, but one thing I would consider is to leave a bit more breathing space about your group title.
I'd play around a bit with padding above & below, but mostly above.

CleanShot 2025-01-10 at 12 46 43@2x

@vanch3d vanch3d force-pushed the feat/29159/integration-adapter-workspace branch from 48dd9b8 to a9334a8 Compare January 10, 2025 12:32
@vanch3d vanch3d merged commit 757254b into master Jan 10, 2025
10 checks passed
@vanch3d vanch3d deleted the feat/29159/integration-adapter-workspace branch January 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants