Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(28895): Fix rendering of metrics for groups #729

Merged
merged 9 commits into from
Jan 10, 2025

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Jan 6, 2025

See https://hivemq.kanbanize.com/ctrl_board/57/cards/28895/details/

The PR fixes a bug in the rendering of the list of metrics available for groups. The process was considering device nodes in the list of available targets for metrics, resulting in a wrong list

Device nodes are now properly excluded from the processing of metrics

Before

screenshot-localhost_3000-2025_01_06-18_43_53

After

screenshot-localhost_3000-2025_01_06-18_44_43

@vanch3d vanch3d self-assigned this Jan 6, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 6, 2025
@vanch3d vanch3d requested a review from sfrehse January 8, 2025 16:44
Copy link
Contributor

@oli-hivemq oli-hivemq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦣

@vanch3d vanch3d force-pushed the fix/28895/metrics-groups branch from e4ccd78 to 49db7e9 Compare January 10, 2025 11:59
@vanch3d vanch3d merged commit f9346b8 into master Jan 10, 2025
9 of 10 checks passed
@vanch3d vanch3d deleted the fix/28895/metrics-groups branch January 10, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants