forked from google/ExoPlayer
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google release v2 merget to release v2 #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: google#3037 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164614478
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164705750
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164706078
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164706135
…changes ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164774783
We've seen more than one issue filed where a developer has registered a video listener and been confused by the fact their SimpleExoPlayerView no longer works properly. There are also valid use cases for having multiple metadata/text outputs. Issue: google#2933 Issue: google#2800 Issue: google#2286 Issue: google#2240 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164839882
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164840037
… encryption feature to be disabled gracefully: encrypted index files may be read, but plaintext will be written. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165196508
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165291627
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165291982
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165293386
If the main thread was interrupted during ExoPlayerImplInternal.blockingSendMessage/release, the interrupted flag was immediately set but then wait() was called on the next iteration. wait() would immediately throw InterruptedException, causing the main thread to spin until the blocking operation completed. Instead of resetting the flag immediately, reset it after the blocking operation completes. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165426493
Issue: google#3171 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165577562
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165580016
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165628229
export setPropertyByteArray, setPropertyString of DefaultDrmSessionManager for easy customization.
Issue: google#3184 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165895259
These methods are only used in one place, and offer duplicate functionality to checking getNext(Previous)WindowIndex == C.INDEX_UNSET. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165910258
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165920927
Issue: google#3191 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165925148
- This is soon becoming mandatory. - It also looks like future versions of com.android.tools.build are being distributed via Google's Maven repository. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=166058299
Make getMediaFormat protected so that subclasses can set additional MediaFormat keys. For example, if the decoder output needs to be read back via an ImageReader as YUV data it is necessary to set KEY_COLOR_FORMAT to COLOR_FormatYUV420Flexible. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=166195211
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=166820970
The bytesRemaining didn't always take into account any skipped bytes, which meant that reaching the end of the file was not correctly detected in read(). Issue: google#3216 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167016672
We currently switch without downloading overlapping segments, but we do not actually switch more aggressively. This change fixes this. Note there's an implicit assumption made that if one media playlist declares independent segments, the others will too. This is almost certainly true in practice, and if it's not the penalty isn't too bad (the player may try and switch to a higher quality variant one segment's worth of buffer too soon). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167120992
Using the same sampler introduced some minor horizontal scratches. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167347995
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167474040
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167488837
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167493800
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167496569
Merge: google#3225 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167502127
Issue: google#3228 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167504122
Issue: google#3215 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167505797
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167579719
Issue: google#3236 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167581198
…set. Reporting incorrect positions for ad playbacks was causing IMA to think the ad wasn't playing, when in fact it was. Issue: google#3180 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167702032
This appears to be fixed in Oreo, but given how harmless the workaround is we can probably just apply it on all API levels to be sure. Issue: google#3160 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167709070
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167711928
Issue: google#3156 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167718081
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=168007345
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=168020525
When creating PlaybackControlView inside SimpleExoPlayerView, we want certain attributes to be passed through. This lets you set control attributes on the SimpleExoPlayerView directly. We don't want all attributes to be propagated though; only our own custom ones. Not sure if there's a cleaner way to do this. Pragmatically this solution seems ... ok :)? ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167619801
…back Resubmit of google#3136 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164971900
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=168155713
Issue: google#3162 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165572088
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165578518
… google-release-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.