Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tx_total_size column nullable #2207

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

rafaelcr
Copy link
Collaborator

Since we just need it for fee estimations, it's ok if this column remains null for past blocks

Copy link

Vercel deployment URL: https://stacks-blockchain-6pikiwvsq-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr marked this pull request as ready for review January 27, 2025 14:50
@rafaelcr rafaelcr requested a review from zone117x January 27, 2025 14:51
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafaelcr rafaelcr merged commit 77bd2f8 into develop Jan 27, 2025
26 of 28 checks passed
@rafaelcr rafaelcr deleted the fix/tx-size-migration branch January 27, 2025 17:05
blockstack-devops pushed a commit that referenced this pull request Jan 28, 2025
## [8.6.0-beta.1](v8.5.0...v8.6.0-beta.1) (2025-01-28)

### Features

* consider tenure block fullness for transaction fee estimations ([#2203](#2203)) ([396e2ea](396e2ea))
* store total transaction size in blocks table ([#2204](#2204)) ([ac7c41b](ac7c41b))

### Bug Fixes

* make tx_total_size column nullable ([#2207](#2207)) ([77bd2f8](77bd2f8))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.6.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Feb 6, 2025
## [8.6.0](v8.5.0...v8.6.0) (2025-02-06)

### Features

* consider tenure block fullness for transaction fee estimations ([#2203](#2203)) ([396e2ea](396e2ea))
* store total transaction size in blocks table ([#2204](#2204)) ([ac7c41b](ac7c41b))

### Bug Fixes

* make tx_total_size column nullable ([#2207](#2207)) ([77bd2f8](77bd2f8))
* use an independent sql connection for mempool stats ([#2217](#2217)) ([f8137e4](f8137e4))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants