Fish support based on macOS support #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create some kind of interface for different OSes: Main functions for setting proxies are split into different files for each OS which contain identical function names. The corresponding file gets sourced at the beginning of the file.
BSD readlink has a different functionality than GNU's readlink. We need to use realpath on macOS.
BSD sed's syntax is different from the GNU one. We check for the OS in the unset function and call the corresponding sed syntax
also removed unnecessary hashtag also added networksetup entry to do_all function
...because this function is not implemented yet.
in networksetup.sh -> set_proxy()
This was a copy and paste error
macOS does not come with realpath per default, so we need a portable substitute for this
... on basis of already supported macOS
by using /usr/bin/env, we can just execute this with fish shell as well
+ make sed command OS independent + use only 1 for-loop for unsetting variables and modify variable to uppercase + make code more readable by splitting variable removal into own function
|
There were some flaws in the code. Fish shell needs environment variables to be explicitely unset with Additionally, the usage of the Commit 75e62e6 fixes this. EDIT: add more information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added support for setting proxy variables in fish shell.
Since fish also supports setting shell variables with bash syntax, we can just use the existing code and let it write into the
config.fishfile.This PR is tested on macOS, but should work on all the other platforms as well, since there is no real difference.
This PR is based on the changes of the macOS support PR, so this should be merged afterwards.
@himanshub16 Please note: I have the same feature lying around without the macOS stuff. So if you like, I could make another PR so you can add fish support earlier. Just drop me a line :)