Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor abnf_check's check_refs() into abnf.checkRefs #27

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

srl295
Copy link
Contributor

@srl295 srl295 commented Jan 9, 2025

  • this is a useful function, so splitting it out and exporting

- this is a useful function, so splitting it out and exporting
@srl295
Copy link
Contributor Author

srl295 commented Jan 9, 2025

hi, it's me again, this is to make it easier to do an abnf_check programmatically

@hildjj
Copy link
Owner

hildjj commented Jan 9, 2025

Please add yourself to the contributors section of package.json as well.

- add myself as contributor
- add license metadata field
@srl295
Copy link
Contributor Author

srl295 commented Jan 9, 2025

Gladly…  i also added the license: field which was missing

@hildjj
Copy link
Owner

hildjj commented Jan 9, 2025

I have no idea why I used the Apache license on this. I normally go MIT.

@hildjj hildjj merged commit c27ef11 into hildjj:main Jan 9, 2025
4 checks passed
@hildjj
Copy link
Owner

hildjj commented Jan 9, 2025

Released in 4.3.1

@srl295 srl295 deleted the externalize-checkRefs branch January 9, 2025 17:49
@srl295
Copy link
Contributor Author

srl295 commented Jan 9, 2025

Hey, thank you much…

Released in 4.3.1

… and used in unicode-org/cldr#4270 16 minutes later. Calling npx … abnf_test got out of hand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants