Correctly handle unicode ranges #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 4 4
Lines 2683 2804 +121
==========================================
+ Hits 2683 2804 +121 ☔ View full report in Codecov by Sentry. |
This should correctly generate UTF-16 ranges for Peggy from any valid ABNF range. Fixes #25.
srl295
approved these changes
Jan 3, 2025
| @@ -5,3 +5,4 @@ examples/*.peggy | |||
| examples/*.pest | |||
| node_modules | |||
| t.abnf | |||
| .cert/ | |||
There was a problem hiding this comment.
yes, its unrelated, but intentional. I've started using hostlocal in local workflows.
|
OK, this is as good as this patch is going to get. I'll take another look at it in the late morning (Denver time) before I land it. |
|
Sgtm
El El vie, ene 3, 2025 a la(s) 6:38 p.m., Joe Hildebrand <
***@***.***> escribió:
… OK, this is as good as this patch is going to get. I'll take another look
at it in the late morning (Denver time) before I land it.
—
Reply to this email directly, view it on GitHub
<#26 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQZM6ZZOMGYBA7AYH6B7L2I4UPJAVCNFSM6AAAAABURLXSOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRZHE3DMNJQG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I was wrong; this is a lot more readable, IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should correctly generate UTF-16 ranges for
Peggy from any valid ABNF range.
Fixes #25.