Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(php) variables should be highlighted as variable #2778

Closed
afilina opened this issue Oct 21, 2020 · 1 comment · Fixed by #2785
Closed

(php) variables should be highlighted as variable #2778

afilina opened this issue Oct 21, 2020 · 1 comment · Fixed by #2785
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language

Comments

@afilina
Copy link

afilina commented Oct 21, 2020

Describe the issue
PHP variables are not highlighted. Most of my code snippets are quite unreadable because of that.

Which language seems to have the issue?
PHP

Expected behavior
(ignore the background)
image

Actual behavior
image

Additional context
I can live without semicolons, but variables in PHP are critical.
@afilina afilina added bug help welcome Could use help from community language labels Oct 21, 2020
@afilina afilina closed this as completed Oct 21, 2020
@joshgoebel
Copy link
Member

A PR would be welcome, this should be a one line fix.

@joshgoebel joshgoebel added the good first issue Should be easier for first time contributors label Oct 21, 2020
@joshgoebel joshgoebel changed the title PHP no variable highlighting (php) variables should be highlighted as variable Oct 21, 2020
taufik-nurrohman added a commit to taufik-nurrohman/highlight.js that referenced this issue Oct 24, 2020
@taufik-nurrohman
Highlight PHP Variable highlightjs#2778
18e3fff
taufik-nurrohman added a commit to taufik-nurrohman/highlight.js that referenced this issue Oct 25, 2020
@taufik-nurrohman
Highlight PHP Variable highlightjs#2778
09626a3
@taufik-nurrohman taufik-nurrohman mentioned this issue Oct 25, 2020
Merged
2 tasks
joshgoebel pushed a commit that referenced this issue Oct 27, 2020
@taufik-nurrohman
enh(php) highlight variables (#2785)
95ad819 
Resolves #2778.

* Also modernize a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enh(php) highlight variables taufik-nurrohman/highlight.js
2 participants
@joshgoebel @afilina