Merge Patch into release #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping version to 1.2.0
probably fall-out from PR-118?
No ticket: Need to explicitly trap "CLOSED" state changes as well;
to then subsequently transition to "Disconnected" if the connection ends up explicitly getting closed (which it does, via the library). This changes the tests to watch to make sure that a "Failed" status change handler does fire, and that the connection then subsequently goes to "Disconnected". Will also be relevant for work being done as part of HIFI-629.
No ticket: Allow "Failed" connection statuses to transition to "Disconnected"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Patch into release to address connection state