Skip to content

Commit

Permalink
Merge pull request #110 from bridie-hifi/bridie-05-17-release
Browse files Browse the repository at this point in the history
Patch release
  • Loading branch information
hd23408 authored May 18, 2021
2 parents 7c8bb6b + d6b18c4 commit ff2e15c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
4 changes: 2 additions & 2 deletions RELEASE_INSTRUCTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
5. Run `git push -u origin <new branch name>` to push the version changes to your branch.
6. Make a new PR against the base repository containing your version changes.
7. Have someone at High Fidelity merge the PR.
2. Make a Pull Request to pull all of the code from the `main` branch **of your fork** into the `release` branch.
- If you followed the instructions from step (1) above, you can make a pull request with a base of `main` and a compare branch of `<new branch name>`.
2. Make a Pull Request to pull all of the code from the `main` branch, **including the new version changes**, into the `release` branch.
- If you followed the detailed instructions from step (1) above, you can make a pull request with a base of `main` and a compare branch of `<new branch name>`.
3. Have the PR reviewed and merged.
4. Once the PR is merged and the latest code is now on the `release` branch, [click here to start drafting a new release](https://github.com/highfidelity/hifi-spatial-audio-js/releases/new).
5. Under "Tag version", input `v<Package Version>`
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "hifi-spatial-audio",
"version": "1.0.2-3",
"version": "1.1.1",
"description": "The High Fidelity Audio Client Library allows developers to integrate High Fidelity's spatial audio technology into their projects.",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down
6 changes: 2 additions & 4 deletions src/classes/HiFiMixerSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -485,10 +485,8 @@ export class HiFiMixerSession {
if (instructionName === "mute") {
let shouldBeMuted: boolean;
if (instructionArguments.length >= 1) {
if (instructionArguments[0] === 1) {
shouldBeMuted = true;
} else if (instructionArguments[0] === 0) {
shouldBeMuted = false;
if (typeof(instructionArguments[0]) === "boolean") {
shouldBeMuted = instructionArguments[0];
}
}
if (shouldBeMuted !== undefined) {
Expand Down

0 comments on commit ff2e15c

Please sign in to comment.