This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
[WIP] Bazel 25 compatibility #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The older version of protobuf is causing a warning like: An illegal reflective access operation has occurred
4415cf1 to
905f377
Compare
|
When do you think this one will be ready? |
|
Early next week if that works. |
55dc9aa to
c3e8963
Compare
|
🤞 |
added 2 commits
May 16, 2019 22:39
Includes updating the _java attribute to use current_java_runtime and get rid of warnings. The current code with more recent versions of Bazel causes a warning about using the deprecated target '@local_jdk//:java' and to use use @bazel_tools//tools/jdk:current_java_runtime instead (see bazelbuild/bazel#5594). Resolves higherkindness#122
|
CI is good. Commits are squashed into something more reasonable. This is ready for review. |
This was referenced May 17, 2019
|
|
||
| bazel_bin=$(bazel info bazel-bin) | ||
| # TODO(Andy Scott): Reenable this test after fixing coverage in Bazel 25 |
There was a problem hiding this comment.
@andyscott @jjudd any idea how to fix coverage? I've tried to get this file working, and managed to make a bit of progress with
diff --git a/rules/common/private/utils.bzl b/rules/common/private/utils.bzl
index b6be98a..ffe03e0 100644
--- a/rules/common/private/utils.bzl
+++ b/rules/common/private/utils.bzl
@@ -83,7 +83,7 @@ def write_launcher(
metadata_file = ctx.actions.declare_file("%s.jacoco_metadata.txt" % ctx.attr.name, sibling = output)
ctx.actions.write(metadata_file, "\n".join([
jar.short_path.replace("../", "external/")
- for jar in jacoco_classpath
+ for jar in jacoco_classpath.to_list()
]))
more_outputs = [metadata_file]
more_substitutions = {
diff --git a/rules/private/phases/phase_test_launcher.bzl b/rules/private/phases/phase_test_launcher.bzl
index d0d107b..15f1bce 100644
--- a/rules/private/phases/phase_test_launcher.bzl
+++ b/rules/private/phases/phase_test_launcher.bzl
@@ -25,7 +25,7 @@ def phase_test_launcher(ctx, g):
ctx,
base = g.coverage.replacements,
).replacements
- coverage_runner_jars = depset(direct = [ctx.files._jacocorunner + ctx.files._lcov_merger])
+ coverage_runner_jars = depset(direct = ctx.files._jacocorunner + ctx.files._lcov_merger)
test_jars = depset(direct = [
coverage_replacements[jar] if jar in coverage_replacements else jar(by "a bit of progress" I mean it now fails during the execution step instead of during analysis). But I am now getting java.lang.NoClassDefFoundError: org/jacoco/agent/rt/internal_b0d6a23/Offline which doesn't have as obvious of a fix. Figured I'd ask if anyone had any ideas before I banged my head against a wall repeatedly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a few extra commits. Currently a work in progress.