-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Pages Documentation site for TCK docs #333
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this idea and I think it would be a great feature to integrate to make our docs more readable. However there are a couple things I noticed on the site that should be fixed before we merge:
- The test specifications use tags with
<
and>
to denote variables in the tests. For example, if a test needs to use the ID of a previously created account, it will look something like<CREATED_ACCOUNT_ID>
. It doesn't look like these show up in the docs, they are just replaced by blank white space. - Links in the test specifications can't be clicked on to go to that URL. Don't know if this is possible to add or not.
- Is there a way to better organize the sidebar? It looks like all the pages are in alphabetical order, but if we could maybe organize them by service like they are in the repo, that would help declutter a bit.
I really like this idea as well! A similar approach has been implemented in the JS SDK, and from what I’ve heard, it’s a well-structured and user-friendly feature. I haven’t personally worked with it yet, but it seems like a great addition. Building on Rob’s comments, I’d also like to suggest an improvement regarding how document titles are displayed. Instead of showing long, technical names like |
@rwalworth @ivaylogarnev-limechain, thanks for the suggestions, I'll work on fixing/adding your suggestions! I do have a quick question though. I was trying to make sure that the documentation didn’t have to be written any differently than it has been, this is a priority I should keep right? |
8d912da
to
a20c8f4
Compare
I think I'd prefer not having to make any major changes, but if you'd want something small to be changed (e.g. using a different form of tagging variables without the |
bb36156
to
edc9721
Compare
Ok sounds good! The stylistic things like environment variables and links work now, but the navigation by service will need a front matter at the top of every md file to work properly. |
19d5b2f
to
306dbc3
Compare
Hi @LukeBair , I reviewed the files again, and for a static HTML setup, everything looks good for now. The SCSS naming conventions are also properly followed—great job! I have two small requests:
Thanks! |
I second this! Also in addition to the instructions on how to launch the page, how we'd be able to test adding new specifications; I'm not sure if there'd be a separate site on which we'd be able to try things out and see potential changes or how that works, so it'd be good to have clarity there. |
I assume you mean the non-documentation files, like all the custom HTML and SCSS; is that correct?
I'm not quite sure what you mean by this. Do you mean that the README should have instructions on how to add to the docs? Maybe the README can have a local build guide to help people test their edits/additions. |
If I were to add new tests specs, I'd want to make sure they show up on the site correctly before I merge. I think it'd be good to have documented whatever the process would look like to verify that. |
Hi @LukeBair, Yes, I was referring to formatting the HTML and SCSS files with Prettier—you’ve done that, great job! Thank you. I was able to run the site locally, and it looks good! The documentation is also clear enough to get the site up and running. However, you might want to add a small disclaimer mentioning that some users may need to run I’m attaching some UI improvement suggestions with screenshots: 1. Dropdown Layout Issue 2. Search Icon Movement 3. Left Sidebar Adjustments |
0bb7504
to
0709b64
Compare
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
Local build (gemfile) and readme, prettier formatting, Nav bar grouping/fixing search/Github flavored markdown styling fixes for smaller screens, overlap issues, color scheme integration Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
954fb2c
to
b4384cf
Compare
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
To make the documentation for the TCK docs a little more available for developers, created a simple structure for hosting the markdown files under /docs/ as a github pages site. I chose a theme that comes with a built in search bar, so thats a nice little feature to have.
No changes to the documentation files have to be made, although new pages added to documentation would need to be added to the index.md file.
If this PR is merged, one setting should get tweaked in the repo settings. Go to 'settings' -> 'pages', and make sure that the source for the site is 'deploy from branch', and the branch is 'main', and the folder to serve from is '/docs'
Examples of the site (hosted on my fork of this repo: https://lukebair.github.io/hiero-sdk-tck/)