Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

861 hip 745 integration tests #862

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Conversation

NicolaMirchev
Copy link
Contributor

Description:
Added more integration tests regarding HIP-745

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • [x ] Tested (unit, integration, etc.)

NikolaMirchev added 2 commits January 31, 2024 15:57
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
@NicolaMirchev NicolaMirchev linked an issue Jan 31, 2024 that may be closed by this pull request
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
NikolaMirchev added 2 commits February 1, 2024 11:36
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc676cc) 72.19% compared to head (447ffc3) 72.24%.

❗ Current head 447ffc3 differs from pull request most recent head d22fe0f. Consider uploading reports for the commit d22fe0f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #862      +/-   ##
===========================================
+ Coverage    72.19%   72.24%   +0.04%     
===========================================
  Files          164      164              
  Lines        26517    26517              
===========================================
+ Hits         19144    19156      +12     
+ Misses        6690     6679      -11     
+ Partials       683      682       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the integration tests for example for AccountCreateTransaction should belong to the integration tests of the specific transaction not having a separate serialize_deserialize_test.go. Also do some investigation on FileAppendTransactions there should be a logic for ChunkedTransaction and add the same tests there if not all of them just demonstrate the old flow and then add a Serialize->Deserialize->Modify the transaction fields a bit and then compare.

EDIT: Didn't see that the TopicMessageSubmitTransaction was a chunked one I guess that you could add some more tests there ignore the FileAppend stuff I mentioned.

NikolaMirchev added 2 commits February 5, 2024 13:22
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NicolaMirchev NicolaMirchev marked this pull request as ready for review February 5, 2024 15:49
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gsstoykov gsstoykov merged commit 9dee012 into develop Feb 5, 2024
6 checks passed
@gsstoykov gsstoykov deleted the 861-hip-745-integration-tests branch February 5, 2024 20:21
NicolaMirchev added a commit that referenced this pull request Feb 6, 2024
* Added more integration test for different transaction types

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>

* Change

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>

* fixed build error

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>

* Refactor

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>

* Fixed test

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>

* Implemeted PR suggestions

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>

* Eddited FileAppendTest

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>

---------

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-745: Integration Tests
2 participants