-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
861 hip 745 integration tests #862
Conversation
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #862 +/- ##
===========================================
+ Coverage 72.19% 72.24% +0.04%
===========================================
Files 164 164
Lines 26517 26517
===========================================
+ Hits 19144 19156 +12
+ Misses 6690 6679 -11
+ Partials 683 682 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the integration tests for example for AccountCreateTransaction should belong to the integration tests of the specific transaction not having a separate serialize_deserialize_test.go
. Also do some investigation on FileAppendTransactions
there should be a logic for ChunkedTransaction
and add the same tests there if not all of them just demonstrate the old flow and then add a Serialize->Deserialize->Modify the transaction fields a bit and then compare.
EDIT: Didn't see that the TopicMessageSubmitTransaction
was a chunked one I guess that you could add some more tests there ignore the FileAppend
stuff I mentioned.
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* Added more integration test for different transaction types Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Change Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * fixed build error Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Refactor Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Fixed test Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Implemeted PR suggestions Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Eddited FileAppendTest Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> --------- Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Description:
Added more integration tests regarding HIP-745
Fixes #
Notes for reviewer:
Checklist