789 add hip 745 optionally send transaction data without required transaction fields #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 17, 2024 14:19
…f it is not locked Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
…nc location eddited testcase Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
added 2 commits
January 19, 2024 15:54
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #857 +/- ##
===========================================
- Coverage 72.47% 72.20% -0.28%
===========================================
Files 164 164
Lines 26202 26514 +312
===========================================
+ Hits 18991 19144 +153
- Misses 6571 6688 +117
- Partials 640 682 +42 ☔ View full report in Codecov by Sentry. |
added 2 commits
January 22, 2024 13:18
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
rokn
approved these changes
Jan 23, 2024
added 2 commits
January 23, 2024 15:26
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
|
NicolaMirchev
added a commit
that referenced
this pull request
Feb 6, 2024
…nsaction fields (#857) * Implemented initial logic about serializing a transaction to bytes, if it is not locked Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Eddited to consider that transaction may not be signed. Refactored func location eddited testcase Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Refactored all transactions Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added one example with token transfer transaction Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Removed lint warnings Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Refactored to check if signedBodyBytes is empty instead of Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added some testcases Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added tests and comments Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added a check inside 'account_create_transaction' for stakedNodeID Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Refactored examples directories Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> --------- Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Initial solution regarding HIP-745
This PR modifies ... in order to support ...
Fixes #
Checklist