Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release notes #855

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Updated release notes #855

merged 1 commit into from
Jan 12, 2024

Conversation

gsstoykov
Copy link
Contributor

Description:
Fixed bug for fetching nodes from Client.

Related issue(s):

Fixes #852

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov self-assigned this Jan 12, 2024
@gsstoykov gsstoykov requested a review from SimiHunjan as a code owner January 12, 2024 12:04
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 407 lines in your changes are missing coverage. Please review.

Comparison is base (e97ed41) 69.75% compared to head (baf8d57) 72.47%.
Report is 12 commits behind head on develop.

Files Patch % Lines
file_append_transaction.go 76.35% 39 Missing and 9 partials ⚠️
contract_call_query.go 62.36% 33 Missing and 2 partials ⚠️
account_allowance_approve_transaction.go 78.23% 31 Missing and 1 partial ⚠️
account_allowance_adjust_transaction.go 76.06% 26 Missing and 2 partials ⚠️
contract_update_transaction.go 88.39% 20 Missing and 6 partials ⚠️
contract_create_transaction.go 88.93% 23 Missing and 2 partials ⚠️
contract_create_flow.go 82.30% 13 Missing and 10 partials ⚠️
account_update_transaction.go 91.78% 14 Missing and 4 partials ⚠️
contract_delete_transaction.go 87.91% 16 Missing and 2 partials ⚠️
ethereum_transaction.go 85.82% 17 Missing and 1 partial ⚠️
... and 26 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #855      +/-   ##
===========================================
+ Coverage    69.75%   72.47%   +2.72%     
===========================================
  Files          164      164              
  Lines        34094    26202    -7892     
===========================================
- Hits         23782    18991    -4791     
+ Misses        8943     6571    -2372     
+ Partials      1369      640     -729     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsstoykov gsstoykov merged commit c7cb717 into develop Jan 12, 2024
8 checks passed
@gsstoykov gsstoykov deleted the updated-CHANGELOG.md branch January 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception occurs when querying account balance
2 participants