Update main #839
Merged
Update main #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed port 5600 from toInsecure and refactored tests Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Removed all references to port 5600 Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Changed old url references to mirror node with the actual one Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Deleted unnecessary print Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> --------- Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
* Added tests Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * assessed_custom_fee test and bug fix Added new test and fixed a bug in _fromProtobuf() func Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added a testcase for AccountAllowanceAdjustTransaction._ValidateNetworkOnIDs Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Reset changes to file account_id_e2e Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added test for getters and setters to contract_create_flow Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added unit tests for 'system_delete_transaction.go' Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added more test for 'system_delete_transaction.go' and new file for 'system_undelete_transaction.go' Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Added go build comments for the test Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Removed 'go.work' file Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> --------- Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
* Uncommented testcase. It is working now Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Eddited go version in go.work Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Fixed a test (regarding issue 825) Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * Removed go.work file Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> * added build comments for unit tests Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech> --------- Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: Antonio Mindov <antonio.mindov@limechain.tech>
|
Kudos, SonarCloud Quality Gate passed!
|
NicolaMirchev
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update main branch
Related issue(s):
Fixes #
Notes for reviewer:
Checklist