Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift coverage to 70 #826

Closed
wants to merge 11 commits into from
Closed

Lift coverage to 70 #826

wants to merge 11 commits into from

Conversation

NicolaMirchev
Copy link
Contributor

Description:

Added more unit tests in different files

This PR modifies couple of test files in order get the coverage higher

Added tests for:

  • account_info.go
  • assessed_custom_fee.go
  • account_id.go
  • contract_create_flow.go
  • system_delete_transaction.go
  • system_undelete_transaction.go

Related issue(s):
(#703 (comment))

NikolaMirchev and others added 10 commits November 7, 2023 11:14
Added test for 'account_info.go' bytes conversion function

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Added new test and fixed a bug in _fromProtobuf() func

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
* Feat: Add populate evm address

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>

* Add tests

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>

* Add tests 2

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>

* Add tests 3

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>

* Add tests 4

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>

* Fix tests

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>

* Fix tests 2

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>

* Fix tests 3

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>

---------

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
…rkOnIDs

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
…system_undelete_transaction.go'

Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (639c8e6) 69.73% compared to head (1fdbf6d) 70.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #826      +/-   ##
===========================================
+ Coverage    69.73%   70.69%   +0.95%     
===========================================
  Files          164      164              
  Lines        34126    34126              
===========================================
+ Hits         23798    24124     +326     
+ Misses        8958     8610     -348     
- Partials      1370     1392      +22     
Files Coverage Δ
assessed_custom_fee.go 55.00% <100.00%> (+55.00%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolaMirchev NicolaMirchev deleted the lift-coverage-to-70 branch November 7, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants