-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lift coverage to 70 #826
Closed
Closed
Lift coverage to 70 #826
+481
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for 'account_info.go' bytes conversion function Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Added new test and fixed a bug in _fromProtobuf() func Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
* Feat: Add populate evm address Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> * Add tests Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> * Add tests 2 Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> * Add tests 3 Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> * Add tests 4 Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> * Fix tests Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> * Fix tests 2 Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> * Fix tests 3 Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> --------- Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com> Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
…rkOnIDs Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
…system_undelete_transaction.go' Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
Signed-off-by: NikolaMirchev <nikola.mirchev@limechain.tech>
NicolaMirchev
force-pushed
the
lift-coverage-to-70
branch
from
November 7, 2023 09:19
0ef234f
to
91a48e4
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #826 +/- ##
===========================================
+ Coverage 69.73% 70.69% +0.95%
===========================================
Files 164 164
Lines 34126 34126
===========================================
+ Hits 23798 24124 +326
+ Misses 8958 8610 -348
- Partials 1370 1392 +22
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added more unit tests in different files
This PR modifies couple of test files in order get the coverage higher
Added tests for:
Related issue(s):
(#703 (comment))