Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Create additional unit/integration tests #1213

Merged
merged 2 commits into from
Jan 13, 2025
Merged

test: Create additional unit/integration tests #1213

merged 2 commits into from
Jan 13, 2025
+272 −15

Conversation

0xivanov
Copy link
Contributor

This PR add unit/integration tests for PrngTransaction and FreezeTransaction and fixes a bug in FreezeTransaction where protobufFromBytes does not map the correct start time.

fixes: #1084

@0xivanov
test: freeze transaction
ef16bc2 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
test: prng transaction
53c2d0d 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Jan 13, 2025
@0xivanov 0xivanov requested review from a team as code owners January 13, 2025 09:44
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
sdk/freeze_transaction.go 88.88% <100.00%> (+88.88%) ⬆️

... and 5 files with indirect coverage changes

gsstoykov
gsstoykov approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sdk/prng_transaction_e2e_test.go Show resolved Hide resolved
@0xivanov 0xivanov merged commit 0487a73 into main Jan 13, 2025
6 checks passed
@0xivanov 0xivanov deleted the create-additional-tests branch January 13, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

Assignees

@0xivanov 0xivanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create unit tests for FreezeTransaction and PrngTransaction
2 participants
@0xivanov @gsstoykov