Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Transaction Receipt and Record consistent with other SDKs #1187

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix: make Transaction Receipt and Record consistent with other SDKs #1187

merged 3 commits into from
Dec 13, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Dec 13, 2024 •
edited
Loading

  • Remove ExpectedDecimals from receipt
  • Add ScheduleRef in receipt
  • Add NextExchangeRate in receipt
  • Add unit and integration tests

Fixes: #1173 and #1172

@0xivanov
fix: make receipt and record consistent with other SDKs
2a1c16c 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Dec 13, 2024
@0xivanov 0xivanov requested review from a team as code owners December 13, 2024 09:15
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
transaction_record.go 57.14% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
transaction_receipt.go 95.55% <100.00%> (+16.94%) ⬆️
transaction_record.go 65.92% <57.14%> (+0.22%) ⬆️

... and 2 files with indirect coverage changes

gsstoykov
gsstoykov reviewed Dec 13, 2024
View reviewed changes
transaction_receipt.go Outdated Show resolved Hide resolved
@0xivanov
chore: fix PR feedback
376abaa 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
gsstoykov
gsstoykov approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xivanov 0xivanov merged commit 4193992 into main Dec 13, 2024
6 checks passed
@0xivanov 0xivanov deleted the fix-inconsistencies-in-receipt-and-record branch December 13, 2024 13:30
@0xivanov 0xivanov mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

Assignees

@0xivanov 0xivanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make transaction_record.go consistent with other SDKs
2 participants
@0xivanov @gsstoykov