Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace key logic from go-ethereum #1124

Merged
merged 9 commits into from
Nov 11, 2024
Merged

chore: Replace key logic from go-ethereum #1124

merged 9 commits into from
Nov 11, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Oct 31, 2024 •
edited
Loading

Description:
Remove /crypto package coming from go-ethereum.

Related issue(s):

Fixes #1113

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov
chore: replace private key
feb2d1d 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: replace public key
d86bf82 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.30303% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.40%. Comparing base (2c22da8) to head (bfdb582).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto.go 78.12% 5 Missing and 2 partials ⚠️
ecdsa_public_key.go 81.25% 1 Missing and 2 partials ⚠️
query.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
+ Coverage   73.37%   73.40%   +0.03%     
==========================================
  Files         181      181              
  Lines       23097    23105       +8     
==========================================
+ Hits        16948    16961      +13     
+ Misses       5396     5392       -4     
+ Partials      753      752       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xivanov
chore: replace verify
50407b7 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: update from main
5716644 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: fix hollow accounts
e231e3f 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: add more tests
3cf3a03 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
Merge branch 'main' into replace-keys
431452a
0xivanov
0xivanov commented Nov 7, 2024
View reviewed changes
query.go Show resolved Hide resolved
@0xivanov 0xivanov marked this pull request as ready for review November 7, 2024 08:47
@0xivanov 0xivanov requested review from a team as code owners November 7, 2024 08:47
gsstoykov
gsstoykov previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

query.go Show resolved Hide resolved
0xivanov
0xivanov commented Nov 8, 2024
View reviewed changes
Copy link
Contributor Author

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge, until /abi and /rlp PRs are merged.

@0xivanov
chore: update from main
d30a5e1 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: remove geth lib
bfdb582 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@0xivanov 0xivanov merged commit f2a7c4b into main Nov 11, 2024
13 checks passed
@0xivanov 0xivanov deleted the replace-keys branch November 11, 2024 11:59
@0xivanov 0xivanov mentioned this pull request Nov 11, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth was automatically assigned from hashgraph/hedera-sdk

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan SimiHunjan was automatically assigned from hashgraph/hedera-sdk-go-maintainers

@agadzhalov agadzhalov Awaiting requested review from agadzhalov agadzhalov was automatically assigned from hashgraph/hedera-sdk-go-maintainers

Assignees

@0xivanov 0xivanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace /crypto from go-ethereum
2 participants
@0xivanov @gsstoykov