chore: remove duplicate conditoinal, commented out panic, and run `go…

… fmt`
hiero-ledger · Dec 24, 2020 · 6f81289 · 6f81289
1 parent 23d94df
commit 6f81289
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/contract_update_transaction.go b/contract_update_transaction.go
@@ -211,10 +211,6 @@ func (transaction *ContractUpdateTransaction) Execute(
 		return TransactionResponse{}, transaction.freezeError
 	}
 
-	if transaction.freezeError != nil {
-		return TransactionResponse{}, transaction.freezeError
-	}
-
 	if !transaction.IsFrozen() {
 		_, err := transaction.FreezeWith(client)
 		if err != nil {

diff --git a/topic_message_query_test.go b/topic_message_query_test.go
@@ -286,7 +286,7 @@ func TestTopicMessageQuery_NoStartTime_Execute(t *testing.T) {
 	assert.NoError(t, err)
 
 	for {
-		if err != nil|| !wait || uint64(time.Since(start).Seconds()) > 30 {
+		if err != nil || !wait || uint64(time.Since(start).Seconds()) > 30 {
 			break
 		}
 

diff --git a/transaction.go b/transaction.go
@@ -25,7 +25,7 @@ type Transaction struct {
 	signedTransactions []*proto.SignedTransaction
 	nodeIDs            []AccountID
 
-	freezeError			error
+	freezeError error
 }
 
 func newTransaction() Transaction {
@@ -40,7 +40,7 @@ func newTransaction() Transaction {
 		transactions:         make([]*proto.Transaction, 0),
 		signedTransactions:   make([]*proto.SignedTransaction, 0),
 		nodeIDs:              make([]AccountID, 0),
-		freezeError: nil,
+		freezeError:          nil,
 	}
 }
 
@@ -291,7 +291,6 @@ func (transaction *Transaction) isFrozen() bool {
 
 func (transaction *Transaction) requireNotFrozen() {
 	if transaction.isFrozen() {
-		//panic("Transaction is immutable; it has at least one signature or has been explicitly frozen")
 		transaction.freezeError = errTransactionIsFrozen
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     	assert.NoError(t, err)
     	for {
-    		if err != nil|| !wait || uint64(time.Since(start).Seconds()) > 30 {
+    		if err != nil || !wait || uint64(time.Since(start).Seconds()) > 30 {
     			break
     		}
@@ Expand Down @@