Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affordances for rate limiting posts and minimum eth balance #8473

Closed
sachben91 opened this issue Jul 15, 2024 · 7 comments
Closed

Affordances for rate limiting posts and minimum eth balance #8473

sachben91 opened this issue Jul 15, 2024 · 7 comments
Assignees
Labels
2 Half day task 3 Full day task enhancement New feature or request
Milestone

Comments

@sachben91
Copy link

sachben91 commented Jul 15, 2024

Description

Based on the decision in #8268 , we have decided to rate limit number of posts that a user can make within a contest, along with requiring that every participant in a contest has a non dust value of eth (> 0.0005). This ticket addresses the user affordances related to this change.

Project Owner

No response

Bucket ID

No response

User Stories / Acceptance Criteria

  • When a user attempts to submit a third post to an active contest within a topic, the "create thread" button should be disabled and the reason communicated to the user as shown below
Screenshot 2024-07-15 at 4 50 15 PM
  • If a topic has more than one contest, then the user should be shown which contests they are eligible to submit entries to and which ones have reached the rate limit of two posts per contest
Screenshot 2024-07-15 at 4 53 52 PM
  • If the wallet that the user has connected has less than the non dust value of eth required, they should be shown the following message below the text box
Screenshot 2024-07-16 at 12 29 56 PM

Design Devlink

designs

Design Screenshot

No response

Additional Context

No response

@sachben91 sachben91 added enhancement New feature or request needs estimate labels Jul 15, 2024
@sachben91 sachben91 added this to the Contests milestone Jul 15, 2024
@sachben91
Copy link
Author

related ticket #8466

@timolegros
Copy link
Collaborator

@sachben91 just checking in on the affordances for admins creating contests and potentially crippling their communities by selecting the wrong topics. Also shouldn't the copy for the token warning say "with at least 0.0005 ETH" rather than "tokens"?

@sachben91
Copy link
Author

@timolegros creating a separate ticket for the admin affordance and yes thanks for the catch, will change that to 0.0005 eth

@sachben91
Copy link
Author

Related ticket #8474

@masvelio
Copy link
Contributor

@sachben91

  1. The designs are based on the updated new thread page while we still have old new thread page. The main difference is that we want to show Insufficient balance error below the user address dropdown, however, we don't have possibility to select the address currently in this view.

In this case we should either :

  • allow user to click create button but then throw the toast error
  • disable create button and place the insufficient balance "inline error" somewhere in the form

Below is comparison between new vs current design for more context:

NEW DESIGN
image

CURRENT DESIGN
image

  1. For those two points:

When a user attempts to submit a third post to an active contest within a topic, the "create thread" button should be disabled and the reason communicated to the user as shown below

and

If a topic has more than one contest, then the user should be shown which contests they are eligible to submit entries to and which ones have reached the rate limit of two posts per contest

we need a backend logic from @rbennettcw. Basically, when we load new thread page we need to be able to display the data right away. Ideally for FE, we should extend GET /topics endpoint. We would need structure like this:

  topics: {
    //existing
    topicId: number;
    topicName: string;
    // added (only active contests)
    contests: { 
      contestId: string;
      contestAddress: string;
      contestName: string;
      submittedEntries: number;
    }[];
  }[];

TLDR:
@sachben91 => let me know whats the decision on point 1
@rbennettcw => let us know if point numer 2 works for you

@masvelio masvelio added 2 Half day task and removed needs estimate labels Jul 16, 2024
@sachben91
Copy link
Author

@masvelio @jessmart1213

disable create button and place the insufficient balance "inline error" somewhere in the form
I think this would be ideal solution because the information is really important. Perhaps the inline error can be under the "topic has ongoing contest" banner and to the left of create thread - Leaving this to jess

@sachben91
Copy link
Author

@masvelio ticket has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Half day task 3 Full day task enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants