-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for compatibility with newer numpy / PyPI #113
base: master
Are you sure you want to change the base?
Conversation
@NelleV the installation error I'd been having was due to PASTIS being installed before numpy, and I resolved it by letting conda install numpy instead of pip. Was there a reason you had the environment.yml written such that pip would install most of the dependencies? And is it okay to make this change re numpy installation? |
@NelleV looks like the tests are currently failing because it's using the pip-installed version of PASTIS instead of the code from this pull request. The errors are precisely what this pull request was created to address... How should I best resolve this? |
Removing PASTIS from the pip-installed packages in environment.yml resolved the above issue, tests are now run using the pull request code. Currently, the only failing test is I'm going to change this line to |
The following cause errors with the current versions of numpy / PyPI:
np.float
no longer exists, must be replace withfloat
ornp.float64
np.bool
no longer exists, must be replace withbool
ornp.bool_
This pull request resolves these issues