Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: BranchingOperation should return all errors from children operations #27

Merged
merged 4 commits into from
Mar 1, 2017

Conversation

RudyCo
Copy link

@RudyCo RudyCo commented Jul 17, 2015

BranchingOperation was renamed to BranchingOperationWithBug.
A test case BranchingOperationFixture emphasizes the behavior of the two classes.

@regisbsb
Copy link

regisbsb commented Aug 3, 2015

Refers to #26

@regisbsb
Copy link

regisbsb commented Mar 1, 2017

Would we need a proper merge request with the Branching operation without the bug?

@RudyCo
Copy link
Author

RudyCo commented Mar 1, 2017 via email

@regisbsb
Copy link

regisbsb commented Mar 1, 2017

Agree. I'm thinking how could we create a sort of performance test unit test.

@ayende
Copy link
Member

ayende commented Mar 1, 2017

at a glance, this looks fine

@RudyCo RudyCo merged commit e0f9470 into hibernating-rhinos:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants