Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concave collision bug #5

Closed
hexus opened this issue Aug 28, 2018 · 2 comments
Closed

Concave collision bug #5

hexus opened this issue Aug 28, 2018 · 2 comments
Assignees
@hexus
Labels
bug Something isn't working

Comments

@hexus
Copy link
Owner

hexus commented Aug 28, 2018

image

Something to do with the top-most collision edge being chosen over the left-most, for the top-right tile. Worsens with greater rotation.
@hexus hexus added the bug Something isn't working label Aug 28, 2018
@hexus hexus self-assigned this Aug 28, 2018
@hexus hexus changed the title Convex collision bug Concave collision bug Sep 8, 2018
@hexus hexus removed their assignment Sep 8, 2018
@hexus hexus self-assigned this May 16, 2019
@hexus
Copy link
Owner Author

hexus commented May 16, 2019 •
edited
Loading

It seems like the left edge is being completely ignored in this situation, because the top is always the shortest separation. 🤔 Resolver.preSolvePosition() runs after shortest separating edge has already been chosen at this point, so we can't just ignore it. It's the finalised collision pair between the sprite body and the tile body. Awkward.

image

Edit: This even happens when everything's axis-aligned. 😬 Not good.

image

hexus added a commit that referenced this issue Nov 24, 2019
@hexus
#5 Started addressing collision issues
f5fd2e3
hexus added a commit that referenced this issue Nov 28, 2019
@hexus
#5 Seem to have fixed concave collision issues
3f2cc7d
hexus added a commit that referenced this issue Nov 28, 2019
@hexus
#5 Removed debug statements
726a748
hexus added a commit that referenced this issue Dec 1, 2019
@hexus
#5 Fixed some issues with edge collision normal range restrictions
12a29f2 
Still some quirks to understand and solve
hexus added a commit that referenced this issue Dec 2, 2019
@hexus
#5 Fixed further issues with edge collision normal range restriction
3345cd1
hexus added a commit that referenced this issue Dec 2, 2019
@hexus
#5 Further fixes
5824997
hexus added a commit that referenced this issue Dec 2, 2019
@hexus
#5 Cleanup
ae069b8
hexus added a commit that referenced this issue Dec 2, 2019
@hexus
#5 Removed debug statements
3ab8398
hexus added a commit that referenced this issue Dec 2, 2019
@hexus
Merge pull request #10 from hexus/bug/#5
c8fbc87 
#5 Fixed concave collision issues
@hexus
Copy link
Owner Author

hexus commented Dec 2, 2019

Addressed by #10.

@hexus hexus closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hexus hexus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hexus