Support :warn_if_outdated in deps #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example:
$ mix deps.get
Resolving Hex dependencies...
Resolution completed in 0.0s
Unchanged:
ecto 3.3.1
ecto_sql 3.3.2
ex_doc 0.1.0
postgrex 0.2.1
warning: the following deps set `warn_if_outdated: true` and are outdated:
* ecto 3.3.2 is available
* ecto_sql 3.3.3 is available
josevalim
reviewed
Jan 13, 2025
lib/hex/remote_converger.ex
Outdated
| if deps_to_warn != [] do | ||
| IO.warn( | ||
| [ | ||
| "the following deps set `warn_if_outdated: true` and are outdated:\n\n", |
There was a problem hiding this comment.
We don't use backticks on Elixir but maybe we do on Hex. Please double check. :)
|
In terms of UX, and this may be a bit tricky finding exact line, but for completeness something like this should be possible most of the time too: 
|
ericmj
approved these changes
Jan 17, 2025
lib/hex/remote_converger.ex
Outdated
|
|
||
| latest_version = | ||
| versions | ||
| |> Enum.filter(&Version.match?(&1, requirement)) |
1e7db74 to
81d3d64
Compare
81d3d64 to
4590e64
Compare
josevalim
reviewed
Jan 21, 2025
josevalim
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: