Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 #45

Merged
merged 1 commit into from
Oct 25, 2021
Merged

V2 #45

merged 1 commit into from
Oct 25, 2021

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Aug 24, 2021

It's been a very long time since last update. + There is the switch from wks 2.x to 3.x
So it deserves a major bump

Before that, maybe also drop node 10 support? And migrate from Travis to GitHub actions?

@tomap
V2
3e669e0 
It's been a very long time since last update. + There is the switch from wks 2.x to 3.x
So it deserves a major bump

Before that, maybe also drop node 10 support? And migrate from Travis to GitHub actions?
yoshinorin
yoshinorin reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before that, maybe also drop node 10 support? And migrate from Travis to GitHub actions?

IMHO, we should drop node 10.x & migrate to GitHub Actions and update all deps.

@tomap
Copy link
Contributor Author

tomap commented Aug 26, 2021

@yoshinorin see #46

@tomap
Copy link
Contributor Author

tomap commented Aug 27, 2021

The changelog of the release should include:

  • Drop node 8 & 10
  • Update from wks V2 to v3

yoshinorin
yoshinorin approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tomap tomap merged commit 8dd9fda into master Oct 25, 2021
@tomap tomap deleted the V2 branch October 25, 2021 18:21
@tomap
Copy link
Contributor Author

tomap commented Oct 25, 2021

Can someone do the npm release?

@yoshinorin
Copy link
Member

Done.
I just published new version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomap @yoshinorin @SukkaW