Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle incomplete reads #7

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

adamsitnik
Copy link
Contributor

.NET 6 has introduced a breaking change for handling incomplete reads from DeflateStream. This was discovered in dotnet/runtime#54538.

Please see dotnet/docs#24649 for more details

@hexawyz
Copy link
Owner

hexawyz commented Jun 23, 2021

Hi,

Thanks for the fix!
I certainly never expected that behavior from an in-memory stream, but I guess it makes sense somehow 😅

@adamsitnik adamsitnik deleted the dotnet6breakingChangeFix branch June 24, 2021 06:34
@adamsitnik
Copy link
Contributor Author

@GoldenCrystal Thank you for merging it so quickly!

I certainly never expected that behavior from an in-memory stream, but I guess it makes sense somehow

I've learned it the hard way that if Read returns an int there is a chance for incomplete read.

May I ask when do you plan to release a new package version to nuget.org? We hope that .NET 6 is soon going to become popular and would expect all users to hit this problem ;)

@hexawyz
Copy link
Owner

hexawyz commented Jun 25, 2021

Apparently I needed to fix problems with the CI, but it seems to be all good now 🙂
I published the new package with your fixes. Thanks again ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants