fix

heseya · Sep 21, 2023 · bde10a1 · bde10a1
1 parent c72e48f
commit bde10a1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/app/Dtos/OrderIndexDto.php b/app/Dtos/OrderIndexDto.php
@@ -18,7 +18,7 @@ public static function instantiateFromRequest(FormRequest|OrderIndexRequest $req
     {
         return new self(
             search: $request->input('search'),
-            sort: $request->input('sort'),
+            sort: $request->input('sort', 'created_at:desc'),
             status_id: $request->input('status_id'),
             shipping_method_id: $request->input('shipping_method_id'),
         );

diff --git a/app/Events/ProductSearchValueEvent.php b/app/Events/ProductSearchValueEvent.php
@@ -2,10 +2,11 @@
 
 namespace App\Events;
 
+use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Events\Dispatchable;
 use Illuminate\Queue\SerializesModels;
 
-class ProductSearchValueEvent
+class ProductSearchValueEvent implements ShouldQueue
 {
     use Dispatchable;
     use SerializesModels;

diff --git a/app/Services/AttributeOptionService.php b/app/Services/AttributeOptionService.php
@@ -9,9 +9,11 @@
 use App\Services\Contracts\MetadataServiceContract;
 use Heseya\Dto\Missing;
 
-class AttributeOptionService implements AttributeOptionServiceContract
+readonly class AttributeOptionService implements AttributeOptionServiceContract
 {
-    public function __construct(private MetadataServiceContract $metadataService) {}
+    public function __construct(
+        private MetadataServiceContract $metadataService,
+    ) {}
 
     public function create(string $attributeId, AttributeOptionDto $dto): AttributeOption
     {
@@ -22,7 +24,9 @@ public function create(string $attributeId, AttributeOptionDto $dto): AttributeO
             ],
             $dto->toArray(),
         );
-        $attributeOption = AttributeOption::create($data);
+
+        /** @var AttributeOption $attributeOption */
+        $attributeOption = AttributeOption::query()->create($data);
 
         if (!($dto->getMetadata() instanceof Missing)) {
             $this->metadataService->sync($attributeOption, $dto->getMetadata());
@@ -35,7 +39,7 @@ public function updateOrCreate(string $attributeId, AttributeOptionDto $dto): At
     {
         if ($dto->id !== null && !$dto->id instanceof Missing) {
             /** @var AttributeOption $attributeOption */
-            $attributeOption = AttributeOption::findOrFail($dto->id);
+            $attributeOption = AttributeOption::query()->findOrFail($dto->id);
             $attributeOption->update($dto->toArray());
 
             ProductSearchValueEvent::dispatch($attributeOption->productAttributes->pluck('product_id')->toArray());