Merge branch 'feature/HES-2128' into 'develop'

Change unlimited shipping errors keys Closes HES-2128 See merge request heseya/core!418
heseya · Oct 4, 2023 · 9eecf44 · 9eecf44
2 parents 6974c83 + 8a64973
commit 9eecf44
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 0 deletions.
diff --git a/app/Enums/ValidationError.php b/app/Enums/ValidationError.php
@@ -60,4 +60,6 @@ final class ValidationError extends Enum
     public const MEDIASLUG = 'VALIDATION_MEDIA_SLUG';
     public const PHONE = 'VALIDATION_PHONE';
     public const AUTHPROVIDERACTIVE = 'VALIDATION_AUTH_PROVIDER_ACTIVE';
+    public const UNLIMITEDSHIPPINGTIME = 'VALIDATION_UNLIMITED_SHIPPING_TIME';
+    public const UNLIMITEDSHIPPINGDATE = 'VALIDATION_UNLIMITED_SHIPPING_DATE';
 }
diff --git a/tests/Feature/ItemTest.php b/tests/Feature/ItemTest.php
@@ -3,6 +3,7 @@
 namespace Tests\Feature;
 
 use App\Enums\ErrorCode;
+use App\Enums\ValidationError;
 use App\Events\ItemCreated;
 use App\Events\ItemDeleted;
 use App\Events\ItemUpdated;
@@ -726,6 +727,70 @@ public function testUpdateWithPartialDataSku($user): void
         Event::assertDispatched(ItemUpdated::class);
     }
 
+    /**
+     * @dataProvider authProvider
+     */
+    public function testUpdateWithInvalidUnlimitedDate($user): void
+    {
+        $this->{$user}->givePermissionTo('items.edit');
+
+        $this->item->update([
+            'shipping_date' => now(),
+        ]);
+
+        Deposit::factory()->create([
+            'quantity' => 20,
+            'from_unlimited' => false,
+            'shipping_date' => now(),
+            'item_id' => $this->item->getKey(),
+        ]);
+
+        $item = [
+            'unlimited_stock_shipping_date' => now()->subDay(),
+        ];
+
+        $this->actingAs($this->{$user})->patchJson(
+            '/items/id:' . $this->item->getKey(),
+            $item,
+        )
+            ->assertUnprocessable()
+            ->assertJsonFragment([
+                'key' => ValidationError::UNLIMITEDSHIPPINGDATE,
+            ]);
+    }
+
+    /**
+     * @dataProvider authProvider
+     */
+    public function testUpdateWithInvalidUnlimitedTime($user): void
+    {
+        $this->{$user}->givePermissionTo('items.edit');
+
+        $this->item->update([
+            'shipping_time' => 4,
+        ]);
+
+        Deposit::factory()->create([
+            'quantity' => 20,
+            'from_unlimited' => false,
+            'shipping_time' => 4,
+            'item_id' => $this->item->getKey(),
+        ]);
+
+        $item = [
+            'unlimited_stock_shipping_time' => 2,
+        ];
+
+        $this->actingAs($this->{$user})->patchJson(
+            '/items/id:' . $this->item->getKey(),
+            $item,
+        )
+            ->assertUnprocessable()
+            ->assertJsonFragment([
+                'key' => ValidationError::UNLIMITEDSHIPPINGTIME,
+            ]);
+    }
+
     /**
      * @dataProvider authProvider
      */