Warn on .bundle/config file presence #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussion at rubygems/bundler#4351 (comment) Also do not load the stored `.bundle` directory. We are passing in all the flags that we need to `bundle install`. If we also store a `.bundle/config` file between builds than if you accidentally include `.bundle/config` file in your repo with a `BUNDLE_WITHOUT` value ,it will get persisted to the `.bundle/config` file to the cache and deleting the file from your repo does not get rid of the problem. The config is un-needed, since we're using all flags all the time, let's not rely on the `.bundle/config` file.
| @@ -558,7 +568,6 @@ def build_bundler | |||
| else | |||
| # using --deployment is preferred if we can | |||
| bundle_command += " --deployment" | |||
| cache.load ".bundle" | |||
There was a problem hiding this comment.
We should warn here if it exists and then either delete it or do a delete later down the line.
There was a problem hiding this comment.
We talked about this in hipchat. You can't detect if a user has created this file or if it was previously generated by Heroku. We've had this change merged into master for some time now and it hasn't caused any issues. Going to deploy.
schneems
added a commit
that referenced
this pull request
Mar 17, 2016
Warn on .bundle/config file presence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion at rubygems/bundler#4351 (comment)
Also do not load the stored
.bundledirectory. We are passing in all the flags that we need tobundle install. If we also store a.bundle/configfile between builds than if you accidentally include.bundle/configfile in your repo with aBUNDLE_WITHOUTvalue ,it will get persisted to the.bundle/configfile to the cache and deleting the file from your repo does not get rid of the problem. The config is un-needed, since we're using all flags all the time, let's not rely on the.bundle/configfile.