-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This adds support for generating binaries for the upcoming Heroku-20 stack, and testing them in CI. The Heroku-20 Dockerfile is based on that for Heroku-18, but with: * the unused `python-{pip-whl,setuptools,wheel}` dependencies removed * `python-pip` replaced with `python3-pip` since the former does not exist on Ubuntu 20.04. The switch to Python 3 pip in the builder image only affects bob-builder, since everything else (such as pip-diff) runs against the Python binaries downloaded as part of the compile. bob-builder has been updated to v0.0.18 to pick up the Python 3 fixes in: heroku-python/bob-builder#48 Before this is merged, the binaries will need to be built/uploaded using the steps here: https://github.com/heroku/heroku-buildpack-python/blob/master/builds/README.md A decision will need to be made about whether to backfill older Python versions, however for now we should at least provide the latest point release of each supported Python branch: https://devguide.python.org/#status-of-python-branches Which are: * `3.5.9` * `3.6.10` * `3.7.7` * `3.8.2` We'll also want to upload at least one version of PyPy, however the current script is for the out of date `pypy3.6-7.2.0`, so we'll want to generate newer binaries for all stacks, which is out of scope for now. Refs W-7485877.
- Loading branch information
Showing
7 changed files
with
48 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
FROM heroku/heroku:20-build | ||
|
||
WORKDIR /app | ||
ENV WORKSPACE_DIR="/app/builds" \ | ||
S3_BUCKET="lang-python" \ | ||
S3_PREFIX="heroku-20/" \ | ||
DEBIAN_FRONTEND=noninteractive \ | ||
STACK="heroku-20" | ||
|
||
RUN apt-get update \ | ||
&& apt-get install --no-install-recommends -y \ | ||
libsqlite3-dev \ | ||
python3-pip \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
COPY requirements.txt /app/ | ||
RUN pip3 install --disable-pip-version-check --no-cache-dir -r /app/requirements.txt | ||
|
||
COPY . /app |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
docopt==0.6.2 | ||
bob-builder==0.0.17 | ||
boto==2.48.0 | ||
bob-builder==0.0.18 | ||
boto==2.49.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,8 @@ | ||
#!/usr/bin/env bash | ||
|
||
if [[ ! "$STACK" ]]; then | ||
echo '$STACK must be set! (heroku-16 | cedar-14)' | ||
if [[ -z "$STACK" ]]; then | ||
echo '$STACK must be set! (eg: `STACK=heroku-18 ./tests.sh`)' | ||
exit 1 | ||
fi | ||
|
||
if [[ "$STACK" == "cedar-14" ]]; then | ||
make test-cedar-14 | ||
exit $? | ||
fi | ||
|
||
if [[ "$STACK" == "heroku-16" ]]; then | ||
make test-heroku-16 | ||
exit $? | ||
fi | ||
|
||
if [[ "$STACK" == "heroku-18" ]]; then | ||
make test-heroku-18 | ||
exit $? | ||
fi | ||
make "test-${STACK}" |