Expand the Node.js metrics script usage to v14.10+ #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
approved these changes
Jan 17, 2024
|
@joshwlewis this could use another review since the metrics script and tests had to be modified to work with Node v14.10.0 and up. I've also restored the native addon for v14 to cover deployments below that supported range. Once it's ready to merge I'll update the required status checks to cover the changes added in |
- also removes the previous native addons which are no longer needed [W-14838650](https://gus.lightning.force.com/lightning/r/a07EE00001iPkvfYAC/view)
fcaf7a5 to
ad0a49f
Compare
joshwlewis
approved these changes
Jan 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation from #1178 was scoped to Node v21+. This PR expands the metrics script to Node v14.10+ for broader usage.
To support customers that may want to keep the previous metrics functionality, setting the
HEROKU_LEGACY_NODE_PLUGIN=truewill opt-out of the new metrics script and install the native addon.W-14838650