Remove dependency on semver.herokuapp.com #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79d7624 to
ae14c9e
Compare
colincasey
approved these changes
Oct 3, 2022
Since: - The app is deprecated and due to be switched off shortly. - The buildpack should have as few dependencies on external resources as possible (particularly those not productionised or behind CDN). - We especially should not have dependencies on `herokuapp.com` domains, given the reduced flexibility and risk of subdomain takeover. Fixes #1015. GUS-W-11843580.
ae14c9e to
31a4725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since:
herokuapp.comdomains, given the reduced flexibility and risk of subdomain takeover.Fixes #1015.
GUS-W-11843580.