Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved Docker things over into the master branch. This is the normal way to do it. Now anyone can jump to any commit and just build the Docker file without understanding npm, php and the Docker config files.
I also moved
--accept-license --accept-gdpr
out of50-speedtest
and intoOoklaTester.php
because it didn't persist well for me.And I removed the
ARCH
environment variable used by50-speedtest
and instead useduname -m
to determine the architecture.There are still some issues with the Docker setup such as php dependencies being installed at runtime, and the web ui should be in a seperate folder (check the Dockerfile). But this is a good start to making it super easy for anyone to self-compile speedtest tracker!
As a side note... when pushing, please please please build with two tags. Version tag and then latest tag. This was an issue here: #680 (comment) and I had to provide a tar.gz to help them out.
I moved the
README.md
from the old docker branch into master asDOCKER.md
and updated it with new build instructions. Here's an example of how you'd normally build multi-arch images with a version tag: