Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker overhaul #683

Closed
wants to merge 2 commits into from
Closed

Conversation

makinori
Copy link

@makinori makinori commented Sep 6, 2021

I moved Docker things over into the master branch. This is the normal way to do it. Now anyone can jump to any commit and just build the Docker file without understanding npm, php and the Docker config files.

I also moved --accept-license --accept-gdpr out of 50-speedtest and into OoklaTester.php because it didn't persist well for me.

And I removed the ARCH environment variable used by 50-speedtest and instead used uname -m to determine the architecture.

There are still some issues with the Docker setup such as php dependencies being installed at runtime, and the web ui should be in a seperate folder (check the Dockerfile). But this is a good start to making it super easy for anyone to self-compile speedtest tracker!

As a side note... when pushing, please please please build with two tags. Version tag and then latest tag. This was an issue here: #680 (comment) and I had to provide a tar.gz to help them out.

I moved the README.md from the old docker branch into master as DOCKER.md and updated it with new build instructions. Here's an example of how you'd normally build multi-arch images with a version tag:

# initialize qemu and buildx
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
docker buildx create --use

# build for arm64/v8 and amd64
cd into/git/repo
docker buildx build --platform linux/arm64/v8,linux/amd64 -t henrywhitaker3/speedtest-tracker:VERSIONHERE -t henrywhitaker3/speedtest-tracker:latest .

# push the image as two tags! the second push will be fast because it's identical to the first
docker push -t henrywhitaker3/speedtest-tracker:VERSIONHERE
docker push -t henrywhitaker3/speedtest-tracker:latest

@masterwishx
Copy link

Now we waiting for approving ?
and to wait for new docker version ?

@henrywhitaker3
Copy link
Owner

Yeah I need to scrap the current docker stuff for this and start again tbh

@henrywhitaker3
Copy link
Owner

Have re-done the docker side of things - going to keep picking changes out of this though @MAKITSUNE, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants