Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo_pluto.jl fails on bulk.amr.vlsv example #134

Closed
tkoskela opened this issue Jan 26, 2023 · 2 comments
Closed

demo_pluto.jl fails on bulk.amr.vlsv example #134

tkoskela opened this issue Jan 26, 2023 · 2 comments

Comments

@tkoskela
Copy link

The Plotting section of the notebook does not work for me with the bulk.amr.vlsv file, maybe that is to be expected since you talk about cell IDs without AMR in the markdown.

This is the error I get

UndefVarError: origin not defined

macro expansion@plots.jl:49[inlined]
apply_recipe(::AbstractDict{Symbol, Any}, ::Vlasiator.MetaVLSV, ::AbstractString)@RecipesBase.jl:289
_process_userrecipes!(::Any, ::Any, ::Any)@user_recipe.jl:36
recipe_pipeline!(::Any, ::Any, ::Any)@RecipesPipeline.jl:70
_plot!(::Plots.Plot, ::Any, ::Any)@plot.jl:208
#plot#139@plot.jl:91[inlined]
var"#contourf#457"(::Base.Pairs{Symbol, V, Tuple{Vararg{Symbol, N}}, NamedTuple{names, T}} where {V, N, names, T<:Tuple{Vararg{Any, N}}}, ::typeof(Plots.contourf), ::Any, ::Vararg{Any})@RecipesBase.jl:410
top-level scope@Local: 3[inlined]

Originally posted by @tkoskela in #122 (comment)

@henry2004y
Copy link
Owner

henry2004y commented Jan 26, 2023

Thanks for reporting! I will update the demos. There has been some API changes recently but I forgot to cover them in the CI tests for Plots.jl. Now it should work for all three example files.

henry2004y added a commit that referenced this issue Jan 27, 2023
henry2004y added a commit that referenced this issue Jan 27, 2023
@tkoskela
Copy link
Author

Works now, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants