Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nix flake #110

Merged
merged 4 commits into from
May 20, 2024
Merged

add nix flake #110

merged 4 commits into from
May 20, 2024

Conversation

honnip
Copy link
Contributor

@honnip honnip commented May 16, 2024

This pr introduces the nix packaging and simple dev shell.

This also allows nix run github:henriklovhaug/md-tui to run the package, which can be tested with nix run github:honnip/md-tui now.

@henriklovhaug
Copy link
Owner

Never used nix before, but I'll try it out. Should the lock file also be committed?

@honnip
Copy link
Contributor Author

honnip commented May 16, 2024

Yes, it's for reproducibility, but without it, it will display an annoying prompt I remember

@henriklovhaug
Copy link
Owner

Alright. Update changelog file, optionally include you name there, and I'll merge it in.

@henriklovhaug
Copy link
Owner

It should also be mentioned in the README

@honnip
Copy link
Contributor Author

honnip commented May 20, 2024

I've simply added a mention of flake because the way package is installed from flake depends on each user's environment.

I committed changes on github web editor, and I couldn't find how to overwrite the history. Squash merge please.

@henriklovhaug henriklovhaug merged commit 40b3b3a into henriklovhaug:main May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants