Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #72 and fix #74 #75

Merged
merged 3 commits into from
Aug 20, 2015
Merged

Fix #72 and fix #74 #75

merged 3 commits into from
Aug 20, 2015

Conversation

rpiaggio
Copy link
Contributor

Fix:
#72: On FieldGroup.commit() fail, provide access to underlying Exception
#74: Integrate Vaadin's automatic DateField<->java.sql.Date Converter

henrikerola pushed a commit that referenced this pull request Aug 20, 2015
@henrikerola henrikerola merged commit 943eba5 into henrikerola:3.2 Aug 20, 2015
@henrikerola
Copy link
Owner

Thanks a lot for your contribution!

@rpiaggio
Copy link
Contributor Author

You are more than welcome and thank you actually for this project!

Please be advised that the change #72 actually breaks compatibility in cases where the string from CommitFailed was accessed (either via error, which could be remedied by adding a @deprecated def error = exception.getMessage) or via pattern matching (which I don't think can be remedied). These cases should be quite rare anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants