Fixed creation of FieldGroup. Now the 'item' property is bound to the pa... #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikerola
pushed a commit
that referenced
this pull request
Mar 5, 2015
Fixed creation of FieldGroup. Now the 'item' property is bound to the pa...
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rent one.
Before this fix there was a defect with an empty 'item' property of a newly created FieldGroup using an item as a parameter, like as follows:
case class Employee(name: String)
val fieldGroup = FieldGroup(ScaladinItem(Employee("some name")))
When getting an item from a fieldGroup, None was always returned.
val i = fieldGroup.item // was always None, because 'protected var itemWrapper' was not initialized.