Add missing stuff

[ndarilek]

Added assorted bits that I'd found myself missing:

AbstractField.valid

AbstractSelect.setItemCaption: Don't know if this should be AbstractSelect.itemCaption, but it felt like I should prepend "set" because it isn't a single variable. Maybe it'd be better modeled as a Map[Any, String] but I don't know enough about Scaladin internals to pull that off.

Select: I was surprised that there was a NativeSelect component but not a plain Select.

[henrikerola]

ComboBox should be used instead of deprecated Select.

[ndarilek]

So is removing Select all that is needed for this to be merged? If so, I can remove the commit.

[henrikerola]

Yes, and other corrections:

• valid should be in the Validatable trait
• Add also getItemCaption

After these it's ok for merge.

[ndarilek]

OK, almost done. One question, how do you want getItemCaption/setItemCaption named since they aren't direct analogues to variables?

For the get case, there appears to be precedent for methods stripping the get:

def selected(itemId: Any) = p.isSelected(itemId)

So I could do:

def itemCaption(item: Any): String = p.getItemCaption(item)

But I'm unclear as to weather:

def itemCaption(item: Any, caption: String) = p.setItemCaption(item, caption)

is as clear/in keeping with style.

Thanks.

[henrikerola]

getItemCaption/setItemCaption is the correct form. I know that there are lots of those non-setter/getter methods that are named like scala setter/getter and that's wrong, they should be fixed.

[ndarilek]

All of the above changes are made and on the branch.

[henrikerola]

Thanks a lot!