Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: UI subclasses initialization. #11

Closed
wants to merge 2 commits into from
Closed

Conversation

david04
Copy link

@david04 david04 commented Feb 13, 2013

Hi!

UI subclasses initialization was not being run.

Best,
David

@henrikerola
Copy link
Owner

Hi David,

Thanks for the patch, please provide also a test that shows what it fixes (i.e. the test case should not pass without your patch)

Thanks,
-Henri

@david04
Copy link
Author

david04 commented May 3, 2013

Hi!

Just one more thing:

I think you may be missing an init() call when creating
ScaladinServletService.

Regards,
David

On 13 February 2013 22:02, Henri Kerola notifications@github.com wrote:

Hi David,

Thanks for the patch, please provide also a test that shows what it fixes
(e.g. the test case should not pass without your patch)

Thanks,
-Henri


Reply to this email directly or view it on GitHubhttps://github.com//pull/11#issuecomment-13520921.

@henrikerola henrikerola closed this May 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants