Navigator with tests and demo #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 13, 2013 18:18
Merge from 3.0 (wrappers for interfaces)
| override def wrapper = super.wrapper.asInstanceOf[Navigator.NavigationStateManager] | ||
|
|
||
| def getState: String = { | ||
| wrapper.state.getOrElse("") |
There was a problem hiding this comment.
should be Some(wrapper.state)
There was a problem hiding this comment.
I was wrong, you code is correct
added 6 commits
February 15, 2013 22:41
merge 3.0
…and changed UI.navigator to return null if not set.
merge upstream/3.0
…oviders based on the viewName
henrikerola
pushed a commit
that referenced
this pull request
Feb 19, 2013
Navigator with tests and demo
|
Thanks a lot! |
|
Thank you, I bet that the time it took you to tutor me to get it done you could have done a couple of Navigators yourself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper for com.vaadin.navigator package.