bug and test name.

henningandersen · May 31, 2024 · ff85285 · ff85285
1 parent 6a7ead0
commit ff85285
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/server/src/main/java/org/elasticsearch/transport/TransportService.java b/server/src/main/java/org/elasticsearch/transport/TransportService.java
@@ -1372,7 +1372,7 @@ public void onConnectionClosed(Transport.Connection connection) {
             // we used to fork to a different thread always to avoid stack overflows, but we avoid doing that now, expecting handlers
             // to handle that themselves instead.
             var executor = handler.executor();
-            if (executor == EsExecutors.DIRECT_EXECUTOR_SERVICE) {
+            if (executor == EsExecutors.DIRECT_EXECUTOR_SERVICE && enableStackOverflowAvoidance) {
                 executor = threadPool.generic();
             }
             if (executor == EsExecutors.DIRECT_EXECUTOR_SERVICE) {

diff --git a/server/src/test/java/org/elasticsearch/transport/TransportServiceLifecycleTests.java b/server/src/test/java/org/elasticsearch/transport/TransportServiceLifecycleTests.java
@@ -236,7 +236,7 @@ public void testOnConnectionClosedUsesHandlerExecutor() {
         }
     }
 
-    public void testOnConnetionCloseStackOverflowAvoidance() {
+    public void testOnConnectionCloseStackOverflowAvoidance() {
         onConnectionClosedUsesHandlerExecutor(
             Settings.builder().put(TransportService.ENABLE_STACK_OVERFLOW_AVOIDANCE.getKey(), true).build(),
             Executors.DIRECT,