Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/sealed-secrets] Upgrade Sealed Secret controller to v0.8 #15800

Merged
merged 2 commits into from
Jul 23, 2019
Merged

[stable/sealed-secrets] Upgrade Sealed Secret controller to v0.8 #15800

merged 2 commits into from
Jul 23, 2019

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Jul 23, 2019 •
edited
Loading

What this PR does / why we need it:

  • Upgrade Sealed Secret controller to v0.8
  • Rename --key-name flag to --key-prefix

Checklist

  • DCO signed
  • Chart Version bumped

@hiddeco
Upgrade Sealed Secret controller to v0.8
b71b6f2 
Signed-off-by: Hidde Beydals <hello@hidde.co>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2019
@hiddeco
Copy link
Contributor Author

hiddeco commented Jul 23, 2019

/assign stefanprodan

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hiddeco. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stefanprodan
stefanprodan approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hidde ⭐️

@stefanprodan
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
@hiddeco
Rename --key-name flag to --key-prefix
cb2a456 
Signed-off-by: Hidde Beydals <hello@hidde.co>
@stefanprodan
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hiddeco, stefanprodan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit c8efb57 into helm:master Jul 23, 2019
@hiddeco hiddeco deleted the stable/sealed-secrets-v0.8 branch July 23, 2019 13:30
@mkmik mkmik mentioned this pull request Jul 25, 2019
Closed
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
@hiddeco
[stable/sealed-secrets] Upgrade Sealed Secret controller to v0.8 (hel…
2b61047 
…m#15800)

* Upgrade Sealed Secret controller to v0.8

Signed-off-by: Hidde Beydals <hello@hidde.co>

* Rename `--key-name` flag to `--key-prefix`

Signed-off-by: Hidde Beydals <hello@hidde.co>
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@hiddeco @kengou
[stable/sealed-secrets] Upgrade Sealed Secret controller to v0.8 (hel…
cd4c60d 
…m#15800)

* Upgrade Sealed Secret controller to v0.8

Signed-off-by: Hidde Beydals <hello@hidde.co>

* Rename `--key-name` flag to `--key-prefix`

Signed-off-by: Hidde Beydals <hello@hidde.co>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@hiddeco
[stable/sealed-secrets] Upgrade Sealed Secret controller to v0.8 (hel…
07deb55 
…m#15800)

* Upgrade Sealed Secret controller to v0.8

Signed-off-by: Hidde Beydals <hello@hidde.co>

* Rename `--key-name` flag to `--key-prefix`

Signed-off-by: Hidde Beydals <hello@hidde.co>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees

@stefanprodan stefanprodan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiddeco @k8s-ci-robot @stefanprodan @helm-bot