Skip to content

Commit

Permalink
[fix](hash join) fix column ref DCHECK failure of hash join node bloc…
Browse files Browse the repository at this point in the history
…k mem reuse (apache#28991)

Introduced by apache#28851, after evaluating build side expr, some columns in resulting block may be referenced more than once in the same block.

e.g. coalesce(col_a, 'string') if col_a is nullable but actually contains no null values, in this case funcition coalesce will insert a new nullable column which references the original col_a.
  • Loading branch information
jacktengg authored and stephen committed Dec 28, 2023
1 parent 4033a3f commit 1d6ef8d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion be/src/vec/exec/join/vhash_join_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ Status HashJoinNode::_materialize_build_side(RuntimeState* state) {
// data from data.
while (!eos && (!_short_circuit_for_null_in_build_side || !_has_null_in_build_side) &&
(!_probe_open_finish || !_is_hash_join_early_start_probe_eos(state))) {
block.clear_column_data();
release_block_memory(block, 1);
RETURN_IF_CANCELLED(state);
{
SCOPED_TIMER(_build_get_next_timer);
Expand Down

0 comments on commit 1d6ef8d

Please sign in to comment.