feat: Default theme palette using 16 terminal colors #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
reviewed
Sep 3, 2021
pickfire
reviewed
Sep 3, 2021
c9ac2fb to
2cbaed5
Compare
archseer
reviewed
Sep 4, 2021
archseer
reviewed
Sep 4, 2021
| palette: mut default, | ||
| } = ThemePalette::default(); | ||
|
|
||
| default.extend(palette); |
There was a problem hiding this comment.
Isn't all of this the same as
let theme = ThemePalette::default();
theme.palette(palette);
theme
There was a problem hiding this comment.
But there is no palette method on ThemePalette ? Also we are merging the user palette onto the default palette so that the defaults can be overridden.
archseer
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #687
Allows using default terminal colors in the theme like so:
This requires that there is no separate[palette]section in the theme file. If it is present, that palette will completely override the default palette (there is no merging).The default palette is merged with the user palette, with the user palette taking precedence.