-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hurl Support #6450
Add Hurl Support #6450
Conversation
It's like [vscode-restclient](https://github.com/Huachao/vscode-restclient) - https://github.com/erasin/tree-sitter-http/tree/main/tests
This seems very niche to me. Functionality like vscode-restclient would certainly live in a plugin IMO and other than that, I can't think of a good use-case for HTTP highlighting in an editor |
I use restclient to test WEB API, so I don't have to switch editor to postman, this is more than enough for my use. |
I am not sure if I found what do you refer to as restclient, but is there a reason why hurl (which I supposed is more popular since I can google it) isn't used instead? https://hurl.dev/ There is tree sitter support for it https://github.com/pfeiferj/tree-sitter-hurl. Or is the |
@pickfire thanks!!! The hurl is awesome. I am a web developer, test api with restclient in vscode, and I has use helix a year time, some times must to switch vscode or postman API for test. The hurl has support cli and chaining requests. It is can replace postman for simple test api, is very good to me. I will change this pr with hurl. |
Ohh fan of Hurl here, I didn't know they had a tree-sitter grammar, hope to see this merged in! |
cc @pfeiferj author to let them know we are using it |
((xml) @injection.content | ||
(#set! injection.language "xml")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be html too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for sending this and hope hurl helps you.
@@ -2421,3 +2421,17 @@ language-server = { command = "nimlangserver" } | |||
[[grammar]] | |||
name = "nim" | |||
source = { git = "https://github.com/aMOPel/tree-sitter-nim", rev = "240239b232550e431d67de250d1b5856209e7f06" } | |||
|
|||
[[language]] | |||
name = "hurl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add # http
so people can search for it? I wonder.
Since the name hurl is not really useful.
I like how doom emacs did it, they put some more description (and funny) description beside the original plugin so people know what is it for.
@the-mikedavis what do you think?
@pickfire thanks for merged. I have been using hurl test api for a few days now, and chaining api better than restclient. |
* Add http Support It's like [vscode-restclient](https://github.com/Huachao/vscode-restclient) - https://github.com/erasin/tree-sitter-http/tree/main/tests * Add Hurl Support
* Add http Support It's like [vscode-restclient](https://github.com/Huachao/vscode-restclient) - https://github.com/erasin/tree-sitter-http/tree/main/tests * Add Hurl Support
* Add http Support It's like [vscode-restclient](https://github.com/Huachao/vscode-restclient) - https://github.com/erasin/tree-sitter-http/tree/main/tests * Add Hurl Support
It's like vscode-restclienthttps://github.com/erasin/tree-sitter-http/tree/main/testsrest-nvim/tree-sitter-http#10Hurl is a cli tool for API request test.