-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql): MariaDB/MySQL syntax, Apache Hive syntax, unified builtin functions, floats, negative integers #6041
Merged
the-mikedavis
merged 12 commits into
helix-editor:master
from
LeoniePhiline:feat/ts-sql-mariadb-hive
Feb 23, 2023
Merged
feat(sql): MariaDB/MySQL syntax, Apache Hive syntax, unified builtin functions, floats, negative integers #6041
the-mikedavis
merged 12 commits into
helix-editor:master
from
LeoniePhiline:feat/ts-sql-mariadb-hive
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COLLATE
, CHARACTER SET
, ENGINE
Ready for review. |
archseer
reviewed
Feb 19, 2023
dead10ck
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me
the-mikedavis
approved these changes
Feb 23, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
…functions, floats, negative integers (helix-editor#6041) * feat(sql): MariaDB/MySQL table options `COLLATE`, `CHARACTER SET`, `ENGINE` Upstream changes: DerekStride/tree-sitter-sql@286e10c...30e15d4 * feat(sql): Optional `COLUMN` in `ALTER TABLE` Upstream changes: DerekStride/tree-sitter-sql@30e15d4...c508e60 * feat(sql): Add `UNSIGNED` support, refactor numeric types Upstream changes: DerekStride/tree-sitter-sql@c508e60...2d1d5b6 * feat(sql): Add support for Apache Spark create Hive table Upstream changes: DerekStride/tree-sitter-sql@2d1d5b6...7be06f4 * feat(sql): Add support for signed and unsigned floating point literals Upstream changes: https://github.com/DerekStride/tree-sitter-sql/pull/92/files * feat(sql): Add interval data type Upstream changes: DerekStride/tree-sitter-sql@13d375d...7b4bcd0 * feat(sql): Add support for DROP INDEX Upstream changes: DerekStride/tree-sitter-sql@7b4bcd0...173d6fe * feat(sql): Add MariaDB/MySQL `ALTER TABLE ... CHANGE|MODIFY ... [FIRST|AFTER]` syntax Upstream changes: DerekStride/tree-sitter-sql@173d6fe...0d7a121 * feat(sql): Extract fields from Apache Hive storage location and row format Upstream changes: DerekStride/tree-sitter-sql@0d7a121...d2f0f66 * feat(sql): Fix unified built-in functions Upstream changes: DerekStride/tree-sitter-sql@d2f0f66...e4e43ba * feat(sql): Support negative integers Upstream changes: DerekStride/tree-sitter-sql@e4e43ba...3a3f92b * rework(sql): Improve `@constant.numeric` regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-language-support
Area: Support for programming/text languages
S-waiting-on-review
Status: Awaiting review from a maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contents
All commits are self-contained, documenting
languages.toml
git ref andruntime/queries/sql/highlights.scm
helix TS queriesper each feature.
Therefore:
Each commit may be reviewed individually.
MariaDB/MySQL table options
COLLATE
,CHARACTER SET
,ENGINE
(2b0ff71)Upstream changes: DerekStride/tree-sitter-sql@286e10c...30e15d4
Optional
COLUMN
keyword inALTER TABLE
(3c8b951)Upstream changes: DerekStride/tree-sitter-sql@30e15d4...c508e60
Add
UNSIGNED
support, refactor numeric types (a564d8d)Upstream changes: DerekStride/tree-sitter-sql@c508e60...2d1d5b6
Add support for Apache Spark create Hive table (2951dcc)
Upstream changes: DerekStride/tree-sitter-sql@2d1d5b6...7be06f4
Add support for signed and unsigned floating point literals (51a1b94 + 4ab3a22)
Upstream changes: https://github.com/DerekStride/tree-sitter-sql/pull/92/files
Add interval data type (4a960c7)
Upstream changes: DerekStride/tree-sitter-sql@13d375d...7b4bcd0
Add support for DROP INDEX (16549e2)
Upstream changes: DerekStride/tree-sitter-sql@7b4bcd0...173d6fe
Add MariaDB/MySQL
ALTER TABLE ... CHANGE|MODIFY ... [FIRST|AFTER]
syntax (4ea492f)Upstream changes: DerekStride/tree-sitter-sql@173d6fe...0d7a121
Extract fields from Apache Hive storage location and row format (1ff0ebd)
Upstream changes: DerekStride/tree-sitter-sql@0d7a121...d2f0f66
Fix unified built-in functions (4b30f1e)
Upstream changes: DerekStride/tree-sitter-sql@d2f0f66...e4e43ba
Support negative integers (afbe26a)
Upstream changes: DerekStride/tree-sitter-sql@e4e43ba...3a3f92b