-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
languages: added elvish #2948
languages: added elvish #2948
Conversation
For the syntax highlighting you'll want to add The captures need to be adapted to the ones helix uses though: https://docs.helix-editor.com/master/themes.html#syntax-highlighting, for example And the ((comment) @injection.content
(#set! injection.language "comment")) |
Also to clear up the Docs CI's ❌, you'll want to run |
So basically that probably needs to be forked to support neovim and helix (different format)? |
We host the queries in this repo (https://github.com/helix-editor/helix/tree/master/runtime/queries) since each editor tends to use their own queries. Technically the injections in that repo are wrong according to |
Not sure if i got them all, but syntax highlighting is working now and i don't see an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you re-run cargo xtask docgen
? It should add a checkmark to the highlight column for elvish. After that I think this should be good to go 👍
Sure. Will do when i'm back home. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, this looks great!
Added elvish. Can't see the grammar taking any effect so there is likely still sth. wrong with the config.